From 0ddfc73bee88c994876787a41540ef847f4fcd4f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= <ivov.src@gmail.com>
Date: Tue, 22 Aug 2023 15:58:23 +0200
Subject: [PATCH] fix(editor): Ensure community node install button tracks user
 agreement (#6976)

https://share.cleanshot.com/2rlsnTpf
---
 .../CommunityPackageInstallModal.vue          |  4 +-
 .../CommunityPackageInstallModal.spec.ts      | 55 +++++++++++++++++++
 2 files changed, 58 insertions(+), 1 deletion(-)
 create mode 100644 packages/editor-ui/src/components/__tests__/CommunityPackageInstallModal.spec.ts

diff --git a/packages/editor-ui/src/components/CommunityPackageInstallModal.vue b/packages/editor-ui/src/components/CommunityPackageInstallModal.vue
index 66bf8470c0fed..3a0b4d75745cd 100644
--- a/packages/editor-ui/src/components/CommunityPackageInstallModal.vue
+++ b/packages/editor-ui/src/components/CommunityPackageInstallModal.vue
@@ -61,6 +61,7 @@
 					:class="[$style.checkbox, checkboxWarning ? $style.error : '', 'mt-l']"
 					:disabled="loading"
 					@update:modelValue="onCheckboxChecked"
+					data-test-id="user-agreement-checkbox"
 				>
 					<n8n-text>
 						{{ $locale.baseText('settings.communityNodes.installModal.checkbox.label') }} </n8n-text
@@ -74,7 +75,7 @@
 		<template #footer>
 			<n8n-button
 				:loading="loading"
-				:disabled="packageName === '' || loading"
+				:disabled="!userAgreed || packageName === '' || loading"
 				:label="
 					loading
 						? $locale.baseText('settings.communityNodes.installModal.installButton.label.loading')
@@ -83,6 +84,7 @@
 				size="large"
 				float="right"
 				@click="onInstallClick"
+				data-test-id="install-community-package-button"
 			/>
 		</template>
 	</Modal>
diff --git a/packages/editor-ui/src/components/__tests__/CommunityPackageInstallModal.spec.ts b/packages/editor-ui/src/components/__tests__/CommunityPackageInstallModal.spec.ts
new file mode 100644
index 0000000000000..4e21495287efe
--- /dev/null
+++ b/packages/editor-ui/src/components/__tests__/CommunityPackageInstallModal.spec.ts
@@ -0,0 +1,55 @@
+import { createComponentRenderer } from '@/__tests__/render';
+import CommunityPackageInstallModal from '../CommunityPackageInstallModal.vue';
+import { createTestingPinia } from '@pinia/testing';
+import { COMMUNITY_PACKAGE_INSTALL_MODAL_KEY, STORES } from '@/constants';
+import userEvent from '@testing-library/user-event';
+import { retry } from '@/__tests__/utils';
+
+const renderComponent = createComponentRenderer(CommunityPackageInstallModal, {
+	props: {
+		appendToBody: false,
+	},
+	data() {
+		return {
+			packageName: 'n8n-nodes-hello',
+		};
+	},
+	pinia: createTestingPinia({
+		initialState: {
+			[STORES.UI]: {
+				modals: {
+					[COMMUNITY_PACKAGE_INSTALL_MODAL_KEY]: { open: true },
+				},
+			},
+			[STORES.SETTINGS]: {
+				settings: {
+					templates: {
+						host: '',
+					},
+				},
+			},
+		},
+	}),
+});
+
+describe('CommunityPackageInstallModal', () => {
+	it('should disable install button until user agrees', async () => {
+		const wrapper = renderComponent();
+
+		await retry(() =>
+			expect(wrapper.container.querySelector('.modal-content')).toBeInTheDocument(),
+		);
+
+		const installButton = wrapper.getByTestId('install-community-package-button');
+
+		expect(installButton).toBeDisabled();
+
+		await userEvent.click(wrapper.getByTestId('user-agreement-checkbox'));
+
+		expect(installButton).toBeEnabled();
+
+		await userEvent.click(wrapper.getByTestId('user-agreement-checkbox'));
+
+		expect(installButton).toBeDisabled();
+	});
+});