From 7923d3b6040e1caaa395691dbd587951c381fa96 Mon Sep 17 00:00:00 2001 From: Jon Date: Mon, 29 Jul 2024 10:05:16 +0100 Subject: [PATCH] feat(Shopify Node): Update Shopify API version (#10155) --- .../credentials/ShopifyAccessTokenApi.credentials.ts | 3 +-- packages/nodes-base/credentials/ShopifyApi.credentials.ts | 3 +-- packages/nodes-base/nodes/Shopify/GenericFunctions.ts | 2 +- packages/nodes-base/nodes/Shopify/Shopify.node.ts | 7 +++++++ 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/packages/nodes-base/credentials/ShopifyAccessTokenApi.credentials.ts b/packages/nodes-base/credentials/ShopifyAccessTokenApi.credentials.ts index 3d47202ca2dbe..282fddedd4c7a 100644 --- a/packages/nodes-base/credentials/ShopifyAccessTokenApi.credentials.ts +++ b/packages/nodes-base/credentials/ShopifyAccessTokenApi.credentials.ts @@ -4,7 +4,6 @@ import type { ICredentialType, INodeProperties, } from 'n8n-workflow'; - export class ShopifyAccessTokenApi implements ICredentialType { name = 'shopifyAccessTokenApi'; @@ -51,7 +50,7 @@ export class ShopifyAccessTokenApi implements ICredentialType { test: ICredentialTestRequest = { request: { - baseURL: '=https://{{$credentials?.shopSubdomain}}.myshopify.com/admin/api/2019-10', + baseURL: '=https://{{$credentials?.shopSubdomain}}.myshopify.com/admin/api/2024-07', url: '/products.json', }, }; diff --git a/packages/nodes-base/credentials/ShopifyApi.credentials.ts b/packages/nodes-base/credentials/ShopifyApi.credentials.ts index aa01dbf01dd12..2efc64609ec00 100644 --- a/packages/nodes-base/credentials/ShopifyApi.credentials.ts +++ b/packages/nodes-base/credentials/ShopifyApi.credentials.ts @@ -6,7 +6,6 @@ import type { IHttpRequestOptions, INodeProperties, } from 'n8n-workflow'; - export class ShopifyApi implements ICredentialType { name = 'shopifyApi'; @@ -63,7 +62,7 @@ export class ShopifyApi implements ICredentialType { test: ICredentialTestRequest = { request: { - baseURL: '=https://{{$credentials.shopSubdomain}}.myshopify.com/admin/api/2019-10', + baseURL: '=https://{{$credentials.shopSubdomain}}.myshopify.com/admin/api/2024-07', url: '/products.json', }, }; diff --git a/packages/nodes-base/nodes/Shopify/GenericFunctions.ts b/packages/nodes-base/nodes/Shopify/GenericFunctions.ts index d2d1852ad6d8c..ff515edfb119b 100644 --- a/packages/nodes-base/nodes/Shopify/GenericFunctions.ts +++ b/packages/nodes-base/nodes/Shopify/GenericFunctions.ts @@ -38,7 +38,7 @@ export async function shopifyApiRequest( const options: IRequestOptions = { method, qs: query, - uri: uri || `https://${credentials.shopSubdomain}.myshopify.com/admin/api/2019-10${resource}`, + uri: uri || `https://${credentials.shopSubdomain}.myshopify.com/admin/api/2024-07/${resource}`, body, json: true, }; diff --git a/packages/nodes-base/nodes/Shopify/Shopify.node.ts b/packages/nodes-base/nodes/Shopify/Shopify.node.ts index 5175dfe6fdae0..a6e8323e7e468 100644 --- a/packages/nodes-base/nodes/Shopify/Shopify.node.ts +++ b/packages/nodes-base/nodes/Shopify/Shopify.node.ts @@ -63,6 +63,13 @@ export class Shopify implements INodeType { }, ], properties: [ + { + displayName: 'Shopify API Version: 2024-07', + type: 'notice', + name: 'apiVersion', + default: '', + isNodeSetting: true, + }, { displayName: 'Authentication', name: 'authentication',