Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Remove "move" action from workflow and credential on community plan #10057

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Jul 15, 2024

Summary

Users on Community edition should not be able to move resources

Related Linear tickets, Github issues, and Community forum posts

PAY-1728

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 15, 2024
@cstuncsik cstuncsik marked this pull request as ready for review July 16, 2024 09:16
Copy link

cypress bot commented Jul 16, 2024

6 flaky tests on run #5996 ↗︎

0 400 0 0 Flakiness 6

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: 0719b7d0c0
Status: Passed Duration: 05:17 💡
Started: Jul 18, 2024 1:23 PM Ended: Jul 18, 2024 1:28 PM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo renaming node using NDV Test Replay Screenshots Video
Flakiness  25-stickies.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Actions > change sticky color Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #10057 ↗︎

Copy link
Contributor

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Have a few small remarks.

packages/editor-ui/src/components/CredentialCard.test.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/components/CredentialCard.vue Outdated Show resolved Hide resolved
packages/editor-ui/src/components/WorkflowCard.test.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/components/WorkflowCard.test.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/components/WorkflowCard.vue Outdated Show resolved Hide resolved
alexgrozav
alexgrozav previously approved these changes Jul 17, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

alexgrozav
alexgrozav previously approved these changes Jul 18, 2024
…ption-showing-on-instances-with-community-license

# Conflicts:
#	packages/editor-ui/src/components/CredentialCard.vue
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 5a9a271 into master Jul 18, 2024
47 of 48 checks passed
@cstuncsik cstuncsik deleted the pay-1728-bug-move-option-showing-on-instances-with-community-license branch July 18, 2024 13:34
@github-actions github-actions bot mentioned this pull request Jul 24, 2024
@janober
Copy link
Member

janober commented Jul 24, 2024

Got released with n8n@1.52.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants