fix(editor): Fix issue with existing credential not opening in HTTP agent tool #10167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegIvaniv
added
the
release/backport
n8n-assistant
bot
added
n8n team
jeanpaul
approved these changes
Jul 24, 2024
Passing run #6126 ↗︎
Details:
Review all test suite changes for PR #10167 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
elsmr
pushed a commit
that referenced
this pull request
Jul 26, 2024
Merged
elsmr
pushed a commit
that referenced
this pull request
Jul 26, 2024
Merged
|
Got released with |
cstuncsik
pushed a commit
that referenced
this pull request
Jul 31, 2024
Merged
cstuncsik
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with the credential modal not opening in the HTTP Tool node. This happens because we except the
credentialsarray to be populated in CredentialEdit.vue but for HTTP Tool Node these credentials are part of regular parameters usingcredentialsSelectparameter type.Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)