Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Invoice Ninja Node): Fix payment types 2 #10462

Merged
merged 3 commits into from
Aug 19, 2024
Merged

fix(Invoice Ninja Node): Fix payment types 2 #10462

merged 3 commits into from
Aug 19, 2024

Conversation

CodeShakingSheep
Copy link
Contributor

Summary

As a follow-up of #10196 to fix #10196 (comment) .

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CodeShakingSheep
Copy link
Contributor Author

Also as a suggestion for the future to prevent these kinds of errors: Would it be possible to add a linter rule that prevents the lint tests from passing if there is a displayOptions object defined for a child parameter of a collection / fixed collection?

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Aug 16, 2024
@Joffcom
Copy link
Member

Joffcom commented Aug 16, 2024

Hey @CodeShakingSheep,

Thanks for the PR, We have created "GHC-169" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@CodeShakingSheep
Copy link
Contributor Author

Hey @Joffcom ,
Thanks for your reply. As this prevents a whole workflow from executing, I believe it should get a high priority for reviewing. My workflows which have the payment create action, are inactive now. And I think this should also be backported. What do you think?

@Joffcom
Copy link
Member

Joffcom commented Aug 17, 2024

Hey @CodeShakingSheep

Looking at it I was sure it worked when I tested it but it looks like I missed something when running it.

I will get this checked on Monday morning and we can work out what to do. If we do another patch release we can look at adding it.

@Joffcom Joffcom merged commit 129245d into n8n-io:master Aug 19, 2024
9 checks passed
MiloradFilipovic added a commit that referenced this pull request Aug 19, 2024
@MiloradFilipovic
Merge branch 'master' into ADO2-64-assistant-e2e-tests
58b82ba 
* master:
  fix(editor): Fix edge button background color in dark mode in new canvas (no-changelog) (#10475)
  feat(editor): Add old execution status rendering in new canvas (no-changelog) (#10473)
  feat(editor): Update cursor behaviour in new canvas (no-changelog) (#10472)
  fix(editor): Add missing control button events to new canvas (no-changelog) (#10471)
  fix: Show input names when node has multiple inputs (#10434)
  fix(editor): Adjust default zoom level in new canvas (no-changelog) (#10469)
  fix(Read/Write Files from Disk Node): Better error handling when file name missing (no-changelog) (#10463)
  fix: Remove unimplemented Postgres credentials options (#10461)
  fix(Invoice Ninja Node): Fix payment types (#10462)
netroy added a commit to netroy/n8n that referenced this pull request Aug 21, 2024
@netroy
🚀 Release 1.56.0 (#58)
a517866 
#
[1.56.0](https://github.com/netroy/n8n/compare/n8n@1.55.0...n8n@1.56.0)
(2024-08-20)


### Bug Fixes

* Better errors in Switch, If and Filter nodes
([n8n-io#10457](https://github.com/netroy/n8n/issues/10457))
([aea82cb](aea82cb))
* **core:** Fix payload property in `workflow-post-execute` event
([n8n-io#10413](https://github.com/netroy/n8n/issues/10413))
([d98e29e](d98e29e))
* **core:** Fix XSS validation and separate URL validation
([n8n-io#10424](https://github.com/netroy/n8n/issues/10424))
([91467ab](91467ab))
* **core:** Use explicit types in configs to ensure valid decorator
metadata ([n8n-io#10433](https://github.com/netroy/n8n/issues/10433))
([2043daa](2043daa))
* **editor:** Add workflow scopes when initializing workflow
([n8n-io#10455](https://github.com/netroy/n8n/issues/10455))
([b857c2c](b857c2c))
* **editor:** Buffer json chunks in stream response
([n8n-io#10439](https://github.com/netroy/n8n/issues/10439))
([37797f3](37797f3))
* **editor:** Fix flaky mapping tests
([n8n-io#10453](https://github.com/netroy/n8n/issues/10453))
([fc6d413](fc6d413))
* **editor:** Highlight matching type in filter component
([n8n-io#10425](https://github.com/netroy/n8n/issues/10425))
([6bca879](6bca879))
* **editor:** Show item count in output panel schema view
([n8n-io#10426](https://github.com/netroy/n8n/issues/10426))
([4dee7cc](4dee7cc))
* **editor:** Truncate long data pill labels in schema view
([n8n-io#10427](https://github.com/netroy/n8n/issues/10427))
([1bf2f4f](1bf2f4f))
* Filter component - improve errors
([n8n-io#10456](https://github.com/netroy/n8n/issues/10456))
([61ac0c7](61ac0c7))
* **Google Sheets Node:** Better error when column to match on is empty
([n8n-io#10442](https://github.com/netroy/n8n/issues/10442))
([ce46bf5](ce46bf5))
* **Google Sheets Node:** Update name and hint for useAppend option
([n8n-io#10443](https://github.com/netroy/n8n/issues/10443))
([c5a0c04](c5a0c04))
* **Google Sheets Node:** Update to returnAllMatches option
([n8n-io#10440](https://github.com/netroy/n8n/issues/10440))
([f7fb02e](f7fb02e))
* **Invoice Ninja Node:** Fix payment types
([n8n-io#10462](https://github.com/netroy/n8n/issues/10462))
([129245d](129245d))
* **n8n Form Trigger Node:** Show basic authentication modal on wrong
credentials ([n8n-io#10423](https://github.com/netroy/n8n/issues/10423))
([0dc3e99](0dc3e99))
* **OpenAI Node:** Throw node operations error in case of openAi client
error ([n8n-io#10448](https://github.com/netroy/n8n/issues/10448))
([0d3ed46](0d3ed46))
* Project Viewer always seeing a connection error when testing
credentials ([n8n-io#10417](https://github.com/netroy/n8n/issues/10417))
([613cdd2](613cdd2))
* Remove unimplemented Postgres credentials options
([n8n-io#10461](https://github.com/netroy/n8n/issues/10461))
([17ac784](17ac784))
* Require mfa code to change email
([n8n-io#10354](https://github.com/netroy/n8n/issues/10354))
([39c8e50](39c8e50))
* **Respond to Webhook Node:** Fix issue preventing the chat trigger
from working ([n8n-io#9886](https://github.com/netroy/n8n/issues/9886))
([9d6ad88](9d6ad88))
* Show input names when node has multiple inputs
([n8n-io#10434](https://github.com/netroy/n8n/issues/10434))
([973956c](973956c))


### Features

* **core:** Support bidirectional communication between specific mains
and specific workers
([n8n-io#10377](https://github.com/netroy/n8n/issues/10377))
([d0fc9de](d0fc9de))
* **Facebook Graph API Node:** Update node to support API v18 - v20
([n8n-io#10419](https://github.com/netroy/n8n/issues/10419))
([e7ee10f](e7ee10f))

Co-authored-by: netroy <196144+netroy@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Aug 21, 2024
Merged
@janober
Copy link
Member

janober commented Aug 21, 2024

Got released with n8n@1.56.0

@netroy netroy mentioned this pull request Aug 21, 2024
Closed
riascho pushed a commit that referenced this pull request Aug 26, 2024
@CodeShakingSheep @riascho
fix(Invoice Ninja Node): Fix payment types (#10462)
866b546
@CodeShakingSheep
Copy link
Contributor Author

Can confirm it works fine now on my instance after upgrading to the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodeShakingSheep @Joffcom @janober