fix(core): Scheduler tasks should not trigger on follower instances #10507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
added
the
release/backport
netroy
changed the title
ivov
approved these changes
Aug 22, 2024
n8n-assistant
bot
added
core
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
✅ All Cypress E2E specs passed |
|
Got released with |
This was referenced Aug 26, 2024
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When n8n is running in multi-main mode, it's possible for a short while for multiple main instances to have active timers for scheduled tasks (until the leadership handover finishes). During this time if a scheduled task is invoked on a non-leader instance, it should simply be ignored.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1607
Review / Merge checklist
release/backport