Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Enable drag and drop in code editors (Code/SQL/HTML) #10888

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Sep 19, 2024

Summary

image image image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1745/add-drag-and-drop-to-code-node
https://linear.app/n8n/issue/NODE-1672/expressions-cant-drag-pills-into-sql-field-any-more
https://linear.app/n8n/issue/NODE-664/dragging-expressions-does-not-work-in-sql-component-postgres-node

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 19, 2024
@elsmr elsmr changed the title feat(editor): Enable drag and drop in code node for runOnceForEachItem mode feat(editor): Enable drag and drop in code editors (Code/SQL/HTML) Sep 23, 2024
ShireenMissi
ShireenMissi previously approved these changes Sep 25, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ShireenMissi ShireenMissi added the tests-needed This PR needs additional tests label Sep 25, 2024
Copy link

cypress bot commented Sep 25, 2024

n8n    Run #7039

Run Properties:  status check passed Passed #7039  •  git commit 0b60854e61: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-1745-add-drag-and-drop-to-code-node
Run status status check passed Passed #7039
Run duration 04m 18s
Commit git commit 0b60854e61: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 432
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit af9e227 into master Sep 25, 2024
34 checks passed
@ShireenMissi ShireenMissi deleted the node-1745-add-drag-and-drop-to-code-node branch September 25, 2024 13:25
This was referenced Oct 2, 2024
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with n8n@1.62.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released tests-needed This PR needs additional tests ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants