-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Google BigQuery Node): Return numeric values as integers #10943
Merged
ShireenMissi
merged 1 commit into
master
from
node-1615-google-bigquery-node-return-integer-values
Sep 25, 2024
Merged
feat(Google BigQuery Node): Return numeric values as integers #10943
ShireenMissi
merged 1 commit into
master
from
node-1615-google-bigquery-node-return-integer-values
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
node/improvement
New feature or request
labels
Sep 24, 2024
ShireenMissi
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
|
n8n Run #7046
Run Properties:
|
Project |
n8n
|
Branch Review |
node-1615-google-bigquery-node-return-integer-values
|
Run status |
Passed #7046
|
Run duration | 04m 23s |
Commit |
88139389ed: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 riascho 🗃️ e2e/*
|
Committer | Ria |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
432
|
View all changes introduced in this branch ↗︎ |
adds schema check and type conversion on query response
ShireenMissi
force-pushed
the
node-1615-google-bigquery-node-return-integer-values
branch
from
September 25, 2024 14:56
fca9d1c
to
8813938
Compare
ShireenMissi
approved these changes
Sep 25, 2024
|
ShireenMissi
approved these changes
Sep 25, 2024
✅ All Cypress E2E specs passed |
ShireenMissi
deleted the
node-1615-google-bigquery-node-return-integer-values
branch
September 25, 2024 15:46
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
n8n team
Authored by the n8n team
node/improvement
New feature or request
Released
tests-needed
This PR needs additional tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Google BigQuery returns a JSON response where numeric values are always strings. This PR adds the option to
Return Integers as Numbers
.Test Setup
select * from [INSERTDATASETNAME].dummy_data;
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1615/community-issue-google-bigquery-node-returns-integer-values-as-string
Google BigQuery Node Returns Integer Values as String Instead of Number #10503
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)