feat(editor): Do not show error for remote options when credentials aren't specified #10944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
OlegIvaniv
previously approved these changes
Sep 24, 2024
OlegIvaniv
reviewed
Sep 24, 2024
|
You are right :) I've added a unit test for this case |
OlegIvaniv
previously approved these changes
Sep 25, 2024
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-309-openai-model-selector-dont-show-error-if-cred-is-missing
|
| Run status |
|
| Run duration | 04m 18s |
| Commit |
|
| Committer | Eugene Molodkin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
431
|
| View all changes introduced in this branch ↗︎ | |
OlegIvaniv
approved these changes
Sep 26, 2024
|
✅ All Cypress E2E specs passed |
burivuhster
deleted the
ai-309-openai-model-selector-dont-show-error-if-cred-is-missing
branch
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For newly inserted nodes, if they have parameters with remote options and credentials aren't set yet, we shouldn't show an error. Change this to the "Set up credential to see options" notice.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/AI-309/openai-model-selector-dont-show-error-if-cred-is-missing
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)