Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Postgres Node): Falsy query parameters ignored #10960

Conversation

michael-radency
Copy link
Contributor

Summary

Postgres Node: v2.5 ignores falsey (0, null, maybe others) value query parameters.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1627/postgres-node-v25-ignores-falsey-0-null-maybe-others-value-query
https://community.n8n.io/t/postgres-node-2-5-ignores-falsey-query-parameters/52141

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Sep 25, 2024
@ShireenMissi ShireenMissi changed the title fix(Postgres Node): Falsy query parameters ignored fix(Postgres Node): Falsey query parameters ignored Sep 26, 2024
@ShireenMissi ShireenMissi changed the title fix(Postgres Node): Falsey query parameters ignored fix(Postgres Node): Falsy query parameters ignored Sep 26, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Sep 26, 2024

n8n    Run #7061

Run Properties:  status check passed Passed #7061  •  git commit 2f72160d10: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-1627-postgres-node-v25-ignores-falsey-0-null-maybe-others-value
Run status status check passed Passed #7061
Run duration 04m 19s
Commit git commit 2f72160d10: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 432
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 4a63cff into master Sep 26, 2024
35 checks passed
@ShireenMissi ShireenMissi deleted the node-1627-postgres-node-v25-ignores-falsey-0-null-maybe-others-value branch September 26, 2024 15:09
This was referenced Oct 2, 2024
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with n8n@1.62.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants