fix(HTTP Request Tool Node): Remove default user agent header #10971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burivuhster
changed the title
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-354-http-tool-does-not-work-on-all-sites-that-do-work-with
|
| Run status |
|
| Run duration | 04m 46s |
| Commit |
|
| Committer | Eugene Molodkin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
430
|
| View all changes introduced in this branch ↗︎ | |
jeanpaul
approved these changes
Sep 26, 2024
|
✅ All Cypress E2E specs passed |
burivuhster
deleted the
ai-354-http-tool-does-not-work-on-all-sites-that-do-work-with
branch
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As HTTP Tool node uses newer
helper.httpRequestand normal HTTP node uses deprecatedhelper.request, they have slightly different in handling user agent header.This PR adds a workaround so that HTTP Tool node behaves the same way as normal HTTP tool (not sending a default
n8nuser agent header).Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/AI-354/change-default-user-agent-in-http-tool-to-the-default-http-node-user
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)