Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Color scheme for a markdown code blocks in dark mode #11008

Merged

Conversation

burivuhster
Copy link
Contributor

Summary

This PR fixes the code highlighting in markdown section for dark mode

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/AI-331/color-scheme-for-a-code-blocks-in-dark-mode

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 30, 2024
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

cypress bot commented Sep 30, 2024

n8n    Run #7095

Run Properties:  status check passed Passed #7095  •  git commit 5fd9c5aeb0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Project n8n
Branch Review ai-331-color-scheme-for-a-code-blocks-in-dark-mode
Run status status check passed Passed #7095
Run duration 04m 24s
Commit git commit 5fd9c5aeb0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Committer Eugene Molodkin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 435
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@burivuhster burivuhster merged commit b20d2eb into master Sep 30, 2024
33 checks passed
@burivuhster burivuhster deleted the ai-331-color-scheme-for-a-code-blocks-in-dark-mode branch September 30, 2024 11:41
This was referenced Oct 2, 2024
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with n8n@1.62.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants