Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Chat Trigger Node): Fix Allowed Origins paramter #11011

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix(Chat Trigger Node): Fix Allowed Origins paramter #11011

merged 2 commits into from
Sep 30, 2024

Conversation

OlegIvaniv
Copy link
Contributor

Summary

This PR addresses issues with the Chat Trigger node's CORS settings and the parameter matching:

  • Corrects the display of the allowedOrigins option, ensuring it appears only for hosted and webhook modes.
  • Fixes the webhook matching logic for Chat Trigger nodes, which previously didn't work due to path and method matching limitations.
  • Exposes commonCORSParameters from the workflow package for reuse.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 30, 2024
burivuhster
burivuhster approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@burivuhster burivuhster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@cypress Cypress
Copy link

cypress bot commented Sep 30, 2024

n8n    Run #7099

Run Properties:  status check passed Passed #7099  •  git commit b277712abd: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project n8n
Branch Review ai-352-chat-trigger-allowed-origins-cors-option-not-available-with
Run status status check passed Passed #7099
Run duration 04m 29s
Commit git commit b277712abd: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Committer Oleg Ivaniv
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 435
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit b5f4afe into master Sep 30, 2024
33 checks passed
@OlegIvaniv OlegIvaniv deleted the ai-352-chat-trigger-allowed-origins-cors-option-not-available-with branch September 30, 2024 13:42
This was referenced Oct 2, 2024
Merged
Merged
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with n8n@1.62.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burivuhster burivuhster burivuhster approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegIvaniv @janober @burivuhster