fix(core): "Respond to Webhook" should work with workflows with waiting nodes #12806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
ivov
previously approved these changes
Jan 28, 2025
| @@ -94,13 +94,15 @@ export class ActiveExecutions { | |||
| await this.executionRepository.updateExistingExecution(executionId, execution); | |||
| } | |||
|
|
|||
| const resumingExecution = this.activeExecutions[executionId]; | |||
There was a problem hiding this comment.
Should we use ActiveExecutions.getExecution every time we access one?
There was a problem hiding this comment.
getExecution throws, and in this case we don't want that.
There was a problem hiding this comment.
It'd be nice to rename to getExecutionOrFail
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
CAT-545-respond-with-wait
|
| Run status |
|
| Run duration | 04m 39s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
433
|
| View all changes introduced in this branch ↗︎ | |
ivov
approved these changes
Jan 28, 2025
|
|
1 similar comment
|
|
ivov
approved these changes
Feb 3, 2025
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an execution goes into the waiting state, we shouldn't remove it from
ActiveExecutions, and instead retain it to be able to use the response-promise and the startedAt timestamp.Related Linear tickets, Github issues, and Community forum posts
CAT-545
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)