fix(core): Fix empty node execution stack #12945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
added
the
release/backport
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
ivov
changed the title
ivov
changed the title
tomi
approved these changes
Jan 30, 2025
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 23s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
433
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
elsmr
pushed a commit
that referenced
this pull request
Feb 3, 2025
Merged
elsmr
pushed a commit
that referenced
this pull request
Feb 3, 2025
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have a persistent issue with
Cannot read properties of undefined (reading 'node')(see Sentry) originally coming from this line.This means that in some cases
nodeExecutionStackis an empty array, but we always expect it to have at least one node. It turns out that there is an exception, namely an execution where the only node to run is a Chat Trigger is one such case. Ideally there should be no exceptions, but I have no context on whether this exception is necessary.In #12525 we added a check to catch this case not knowing about this Chat Trigger exception, switching from
nodeExecutionStack[0]tonodeExecutionStack.at(0)?.to report it cleanly.Summary
This PR removes the check but keeps the
.at(0)?.optional access to allow this case to go through. See before without check, before with check, and after this PR.Related Linear tickets, Github issues, and Community forum posts
https://n8nio.sentry.io/issues/6224246597
https://n8nio.sentry.io/issues/6130480643
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)