Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Make AI transform node read only in executions view #12970

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jan 31, 2025

Summary

Make AI transform node read only in executions view

Test

  • Copy/paste an AI Transform node from cloud
  • Run workflow
  • Go to executions view, instructions should not be editable

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2335/instructions-in-ai-transform-node-are-editable-in-execution-view

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@dana-gill dana-gill self-requested a review January 31, 2025 09:07
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 31, 2025
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 31, 2025

n8n    Run #9067

Run Properties:  status check passed Passed #9067  •  git commit 7c476259dd: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-2335-instructions-in-ai-transform-node-are-editable-in-execution
Run status status check passed Passed #9067
Run duration 04m 28s
Commit git commit 7c476259dd: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 433
View all changes introduced in this branch ↗︎

@elsmr elsmr merged commit ce1deb8 into master Feb 3, 2025
37 checks passed
@elsmr elsmr deleted the node-2335-instructions-in-ai-transform-node-are-editable-in-execution branch February 3, 2025 07:50
This was referenced Feb 5, 2025
@janober
Copy link
Member

janober commented Feb 6, 2025

Got released with n8n@1.78.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants