Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix showing and hiding canvas edge toolbar when hovering #13009

Merged

Conversation

alexgrozav
Copy link
Member

Summary

Screen.Recording.2025-02-03.at.12.37.11.mov
  • Hiding toolbar after 600ms delay when hovering
  • Keeping toolbar visible when edge is selected

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-585/canvas-ui-the-trash-icon-keeps-running-away-from-me

Fixes #12904 and #12988

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav added the release/backport Changes that need to be backported to older releases. label Feb 3, 2025
@alexgrozav alexgrozav self-assigned this Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rc/components/canvas/elements/edges/CanvasEdge.vue 94.73% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

cypress bot commented Feb 3, 2025

n8n    Run #9078

Run Properties:  status check passed Passed #9078  •  git commit 701d7bd20f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-585-canvas-ui-the-trash-icon-keeps-running-away-from-me
Run status status check passed Passed #9078
Run duration 04m 28s
Commit git commit 701d7bd20f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 433
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 3, 2025
@alexgrozav alexgrozav merged commit ac7bc4f into master Feb 3, 2025
37 checks passed
@alexgrozav alexgrozav deleted the cat-585-canvas-ui-the-trash-icon-keeps-running-away-from-me branch February 3, 2025 12:41
@github-actions github-actions bot mentioned this pull request Feb 3, 2025
@github-actions github-actions bot mentioned this pull request Feb 3, 2025
@janober
Copy link
Member

janober commented Feb 3, 2025

Got released with n8n@1.77.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete connections between nodes because of hidden icons - sometime it works
3 participants