refactor: Add reusable frontend composables package
#13077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
reviewed
Feb 5, 2025
| @@ -0,0 +1,18 @@ | |||
| { | |||
| "name": "@n8n/frontend-typescript-config", | |||
There was a problem hiding this comment.
maybe we should create a new package for all tsconfigs, that backend and nodes packages can also benefit from?
There was a problem hiding this comment.
I would like that. Are you ok with doing this change for the backend in a separate PR?
There was a problem hiding this comment.
I think we should do that and the eslint changes in a separate PR.
There was a problem hiding this comment.
Created follow up ticket here: https://linear.app/n8n/issue/CAT-623/create-reusable-eslint-and-tsconfig-config-packages
tomi
reviewed
Feb 5, 2025
n8n-assistant
bot
added
n8n team
netroy
previously requested changes
Feb 5, 2025
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
tomi
approved these changes
Feb 6, 2025
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
cat-621-create-reusable-frontend-composables-package
|
| Run status |
|
| Run duration | 04m 25s |
| Commit |
|
| Committer | Alex Grozav |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
433
|
| View all changes introduced in this branch ↗︎ | |
alexgrozav
deleted the
cat-621-create-reusable-frontend-composables-package
branch
Merged
|
Got released with |
tomi
changed the title
composables packagecomposables package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the Frontend restructuring initiative, we're adding a separate
@n8n/frontend-composablespackage that will contain all standalone composables. This PR also provides individual tooling packages.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-621/create-reusable-frontend-composables-package
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)