-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Same version of merge node behaves differently after n8n update #13106
fix(core): Same version of merge node behaves differently after n8n update #13106
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code lives in a method that's over 800 lines long. We can't really add unit tests for this. But I'll refactor this part of code and add tests for it soon.
5bd1be1
to
9718ac9
Compare
n8n
|
Project |
n8n
|
Branch Review |
node-2297-community-issue-same-version-of-merge-node-behaves-differently-after
|
Run status |
|
Run duration | 04m 30s |
Commit |
|
Committer | कारतोफ्फेलस्क्रिप्ट™ |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
5
|
|
0
|
|
434
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
…-issue-same-version-of-merge-node-behaves-differently-after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added tests for this, but they currently don't work because our testing framework has some bug with evaluating inputs
expression for merge nodes.
✅ All Cypress E2E specs passed |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Got released with |
Summary
This PR fixes an issue introduced in #11955 by changing the shape of Merge Node return data
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2297/community-issue-same-version-of-merge-node-behaves-differently-after
fixes #12778
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)