Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Same version of merge node behaves differently after n8n update #13106

Conversation

ShireenMissi
Copy link
Contributor

@ShireenMissi ShireenMissi commented Feb 6, 2025

Summary

This PR fixes an issue introduced in #11955 by changing the shape of Merge Node return data

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2297/community-issue-same-version-of-merge-node-behaves-differently-after
fixes #12778

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 6, 2025
netroy
netroy previously approved these changes Feb 6, 2025
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code lives in a method that's over 800 lines long. We can't really add unit tests for this. But I'll refactor this part of code and add tests for it soon.

@netroy netroy force-pushed the node-2297-community-issue-same-version-of-merge-node-behaves-differently-after branch from 5bd1be1 to 9718ac9 Compare February 6, 2025 18:26
netroy
netroy previously approved these changes Feb 6, 2025
Copy link

cypress bot commented Feb 6, 2025

n8n    Run #9182

Run Properties:  status check passed Passed #9182  •  git commit 4620957eb4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ShireenMissi 🗃️ e2e/*
Project n8n
Branch Review node-2297-community-issue-same-version-of-merge-node-behaves-differently-after
Run status status check passed Passed #9182
Run duration 04m 30s
Commit git commit 4620957eb4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ShireenMissi 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 434
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Feb 6, 2025

✅ All Cypress E2E specs passed

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added tests for this, but they currently don't work because our testing framework has some bug with evaluating inputs expression for merge nodes.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit df8f059 into master Feb 10, 2025
38 checks passed
@ShireenMissi ShireenMissi deleted the node-2297-community-issue-same-version-of-merge-node-behaves-differently-after branch February 10, 2025 14:01
Copy link

sentry-io bot commented Feb 11, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'error') ?(workflow-execute.ts) View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot mentioned this pull request Feb 13, 2025
@janober
Copy link
Member

janober commented Feb 13, 2025

Got released with n8n@1.79.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same version of merge node behaves differently after n8n update
3 participants