fix(OpenAI Node): Limit chat history to context window when using memory #13137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
OlegIvaniv
approved these changes
Feb 10, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-656-community-issue-postgres-chat-memory-node-returns-full-table
|
| Run status |
|
| Run duration | 04m 32s |
| Commit |
|
| Committer | JP van Oosten |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
434
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
jeanpaul
deleted the
ai-656-community-issue-postgres-chat-memory-node-returns-full-table
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the OpenAI "message assistant" operation with memory, the full chat history would be sent to the assistant, instead of limiting to the context window configured in the memory node. This should now be fixed by leveraging the
loadMemoryVariablesmethod.Related Linear tickets, Github issues, and Community forum posts
Fixes #12958
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)