Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Microsoft OneDrive Node): Try to download file using downloadUrl #13200

Conversation

ShireenMissi
Copy link
Contributor

Summary

in case download fails for /drive/items/${fileId}/content endpoint try to download file using downloadUrl from file meta

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2169/community-issue-onedrive-download-fails-with-error-401
fixes #12225

@ShireenMissi ShireenMissi changed the title Node 2169 community issue onedrive download fails with error 401 fix(Microsoft OneDrive Node): Try to download file using downloadUrl Feb 11, 2025
Copy link

cypress bot commented Feb 11, 2025

n8n    Run #9246

Run Properties:  status check passed Passed #9246  •  git commit 38eb635d9a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ShireenMissi 🗃️ e2e/*
Project n8n
Branch Review node-2169-community-issue-onedrive-download-fails-with-error-401
Run status status check passed Passed #9246
Run duration 04m 38s
Commit git commit 38eb635d9a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ShireenMissi 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 436
View all changes introduced in this branch ↗︎

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Feb 11, 2025
…community-issue-onedrive-download-fails-with-error-401
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nodes/Microsoft/OneDrive/MicrosoftOneDrive.node.ts 77.77% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 67cd05c into master Feb 12, 2025
37 checks passed
@michael-radency michael-radency deleted the node-2169-community-issue-onedrive-download-fails-with-error-401 branch February 12, 2025 12:46
@github-actions github-actions bot mentioned this pull request Feb 13, 2025
@janober
Copy link
Member

janober commented Feb 13, 2025

Got released with n8n@1.79.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onedrive download fails with error 401
3 participants