Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salesforce "get all" boolean conditions fail #3514

Open
cromulus opened this issue Jun 14, 2022 · 9 comments
Open

salesforce "get all" boolean conditions fail #3514

cromulus opened this issue Jun 14, 2022 · 9 comments
Labels
in linear Issue or PR has been created in Linear for internal review node/issue Issue with a node

Comments

@cromulus
Copy link

Describe the bug
Boolean conditions in the salesforce node fail with the error:
id,name,type FROM Account WHERE Is_this_a_food_pantry__c = '{{true}}' ^ ERROR at Row:1:Column:40 value of filter criterion for field 'Is_this_a_food_pantry__c' must be of type boolean and should not be enclosed in quotes

To Reproduce
Steps to reproduce the behavior:

  1. create a salesforce node
  2. set to "get all"
  3. choose resource "User"
  4. add condition: "Active" = true
  5. Execute node and see error

Expected behavior
I expect to have the node respond with all active users.

Environment (please complete the following information):

  • OS: Docker
  • n8n Version: 0.181.2
  • Node.js Version: v16.15.0
  • Database system: postgres
  • Operation mode: own & queue

Additional context
Add any other context about the problem here.

@Joffcom
Copy link
Member

Joffcom commented Jun 15, 2022

Hey @cromulus,

Thanks for the report, I take it the error is from where you tried {{true}} as a value and not just true? I suspect we are sending all values as strings rather than different data types which Salesforce looks to be expecting. I will flag this up so we can investigate further.

@Joffcom Joffcom added the node/issue Issue with a node label Jun 15, 2022
@cromulus
Copy link
Author

I tried both, and got the same error.

@cromulus
Copy link
Author

Bump!

@Joffcom
Copy link
Member

Joffcom commented Aug 19, 2022

Hey @cromulus,

Thanks for the reminder on this one, Just to double check when you input {{true}} is it showing as an expression in the UI or do you see {{true}}?

@cromulus
Copy link
Author

It's showing as an expression in the UI. green little rectangle with the word "true" in it.

@kevinlitt
Copy link

getting same error here.

@TornMarketing
Copy link

Any resolution to this? I raised this back in 2020 and figured we would have purged this issue by now

How do we query without quotes?

checkbox_custom_field__c = 'false' ^ ERROR at Row:1:Column:79 value of filter criterion for field 'checkbox_custom_field__c ' must be of type boolean and should not be enclosed in quotes

https://community.n8n.io/t/salesforce-get-with-limits-ie-lastmodified-or-email/3631
#1292

@Joffcom
Copy link
Member

Joffcom commented Oct 28, 2022

Hey @TornMarketing,

Not yet, in theory using the expression should have resolved it as a temporary solution but I got caught up with some other issues.

I will bump this one back up my list and see if I can get it sorted either today or early next week.

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Jan 18, 2023
@Joffcom
Copy link
Member

Joffcom commented Jan 18, 2023

Quick update, We are tracking this one internally as NODE-182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review node/issue Issue with a node
Projects
None yet
Development

No branches or pull requests

4 participants