Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n8n sending invalid GET requests #3620

Closed
pemontto opened this issue Jun 30, 2022 · 1 comment · Fixed by #3621
Closed

n8n sending invalid GET requests #3620

pemontto opened this issue Jun 30, 2022 · 1 comment · Fixed by #3621

Comments

@pemontto
Copy link
Contributor

Describe the bug
n8n's axios library appears to send invalid GET requests with an HTTP body. While most services accept this, intermediate proxies often reject them. I have confirmed this occurs with both Github and Clockify nodes.

To Reproduce
Steps to reproduce the behavior:

  1. Configure http_proxy and https_proxy environment variables to use an http proxy
  2. Add a Github or Clockify node, potentially others
  3. Configure a resource and operation that makes a GET request
    • Github: Resource: User, Operation: Get Repositories
    • Clockify: Resource: Workspace, Operation: Get all
  4. Send the request
  5. See error

Packet capture showing empty body with GET request:
SCR-20220630-ev4-2

Squid proxy error:
SCR-20220630-eu2

Expected behavior
GET requests should not have request bodies. Although not strictly prohibited by the spec, a GET body has no semantic meaning. Similar to Python requests library a GET request with a body should be considered invalid.

>>> requests.get(url='http://ipinfo.io', body='')
TypeError: request() got an unexpected keyword argument 'body'

Environment (please complete the following information):

  • OS: MacOS 12 & Docker Alpine
  • n8n Version: 0.184.0
  • Node.js Version: v16.15.1
  • Database system: SQLite & PostgreSQL
  • Operation mode: own & queue

Additional context
None

@Joffcom
Copy link
Member

Joffcom commented Jul 25, 2023

@pemontto as you have put in a PR for this I am going to close this and we can handle this on the PR.

@Joffcom Joffcom closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants