Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate PostHog into n8n #3865

Merged
merged 19 commits into from
Aug 19, 2022
Merged

Integrate PostHog into n8n #3865

merged 19 commits into from
Aug 19, 2022

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 10, 2022

No description provided.

@ivov ivov mentioned this pull request Aug 10, 2022
Closed
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 10, 2022
ahsanv
ahsanv reviewed Aug 18, 2022
View reviewed changes
Copy link
Member

@ahsanv ahsanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Minor comments and nitpicks. Approval pending final testing.

packages/cli/src/ExternalHooks.ts Outdated Show resolved Hide resolved
packages/cli/src/telemetry/index.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/components/Telemetry.vue Outdated Show resolved Hide resolved
ahsanv
ahsanv approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@ahsanv ahsanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ivov ivov merged commit 43e054f into master Aug 19, 2022
@ivov ivov deleted the n8n-4151-integrate-posthog-into-n8n branch August 19, 2022 13:35
@janober janober added the Upcoming Release Will be part of the upcoming release label Aug 24, 2022
@janober
Copy link
Member

janober commented Aug 24, 2022

Got released with n8n@0.192.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsanv ahsanv ahsanv approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @ahsanv