Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HTTP Node): fix instance crashing when batching enabled #3902

Merged
merged 6 commits into from
Sep 15, 2022
Merged

fix(HTTP Node): fix instance crashing when batching enabled #3902

merged 6 commits into from
Sep 15, 2022

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Aug 19, 2022 •
edited
Loading

@RicardoE105 RicardoE105 changed the title 🐛 Fix instance crashing when batching enabled 🐛 Fix instance crashing when batching enabled - N8N-4333 Aug 19, 2022
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Aug 19, 2022
krynble
krynble previously approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ricardo, I've made a small change adding the simple behavior to the NodeExecuteFunctions file since it was missing.

It works as intended now.

krynble
krynble previously approved these changes Aug 30, 2022
View reviewed changes
@RicardoE105 RicardoE105 changed the title 🐛 Fix instance crashing when batching enabled - N8N-4333 fix(HTTP Node): fix instance crashing when batching enabled Sep 9, 2022
krynble
krynble approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Smart approach

@RicardoE105 RicardoE105 merged commit 0ab89ad into master Sep 15, 2022
@RicardoE105 RicardoE105 deleted the fix/http-node branch September 15, 2022 20:32
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 15, 2022
@janober
Copy link
Member

janober commented Sep 21, 2022

Got released with n8n@0.195.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 21, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
@RicardoE105 @krynble
fix(HTTP Node): fix instance crashing when batching enabled (n8n-io#3902
b8eeca6 
)

* 🐛 Fix instance crashing when batching enabled

* Add flag parsing for simple mode

* 🐛 Fix issue with simple flag

* ⚡ improvements

* ⚡ Improvements

* 🔥 Remove console.log

Co-authored-by: Omar Ajoue <krynble@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RicardoE105 @janober @krynble