Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature flag check when PH is unavailable #3944

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 25, 2022

No description provided.

@ivov ivov requested a review from krynble August 25, 2022 11:07
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 25, 2022
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with and without the disable flags

@ivov
Copy link
Contributor Author

ivov commented Aug 25, 2022

Thank you. Confirmed internally that this was also tested with an adblocker.

@ivov ivov merged commit 93c26da into master Aug 25, 2022
@ivov ivov deleted the fix-feature-flag-check-when-ph-unavailable branch August 25, 2022 13:11
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Aug 25, 2022
@janober
Copy link
Member

janober commented Aug 25, 2022

Got released with n8n@0.191.2

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants