feat(RabbitMQ Trigger Node): Automatically reconnect on disconnect #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
reviewed
Sep 28, 2022
| // eslint-disable-next-line @typescript-eslint/no-unsafe-argument | ||
| this.executeErrorWorkflow(error, workflowData, 'internal'); | ||
|
|
||
| // Keep on trying to activate the workflow | ||
| this.addQueuedWorkflowActivation('init', workflowData); |
There was a problem hiding this comment.
Would it make sense to check for the error type here? as in, retry only if it's a network issue.
netroy
approved these changes
Sep 28, 2022
|
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
…8n-io#4019) * feat(RabbitMQ Trigger Node): Automatically reconnect on disconnect * ⚡ Retry indefinetly * ⚡ Also automatically retry activation issues on startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue #1988
https://community.n8n.io/t/no-reconnect-if-rabbitmq-server-restarts/5572