Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Optimise serving static assets #4182

Merged
merged 5 commits into from
Sep 29, 2022
Merged

feat(cli): Optimise serving static assets #4182

merged 5 commits into from
Sep 29, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Sep 23, 2022 •
edited
Loading

@linear
Copy link

linear bot commented Sep 23, 2022

N8N-4739

@netroy netroy force-pushed the N8N-4739-static-server-optimizations branch from 9f652be to 573d443 Compare September 23, 2022 20:49
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 23, 2022
@netroy netroy force-pushed the N8N-4739-static-server-optimizations branch from 7658199 to f9f4c1d Compare September 28, 2022 10:50
@netroy netroy force-pushed the N8N-4739-static-server-optimizations branch from f9f4c1d to d180cc8 Compare September 28, 2022 15:48
@netroy netroy changed the title feat(cli): Optimise serving static assets feat(cli): Optimise serving static assets - N8N-4805 Sep 28, 2022
@linear
Copy link

linear bot commented Sep 28, 2022

N8N-4805

@netroy netroy changed the title feat(cli): Optimise serving static assets - N8N-4805 feat(cli): Optimise serving static assets Sep 28, 2022
alexgrozav
alexgrozav approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, @netroy. 🙌

@netroy netroy merged commit 8b0ccc0 into master Sep 29, 2022
@netroy netroy deleted the N8N-4739-static-server-optimizations branch September 29, 2022 09:27
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 29, 2022
@janober
Copy link
Member

janober commented Sep 30, 2022

Got released with n8n@0.196.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 30, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
@netroy
feat(cli): Optimise serving static assets (n8n-io#4182)
05f268e 
* simplify static server setup

* use consistent ignoredEndpoints across all routes

* remove unnecessary lodash usage

* stop keeping generated assets in memory

* pre-generate all static assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgrozav alexgrozav alexgrozav approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @alexgrozav