Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pindata): Fix excess run in partial execution #4185

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Sep 26, 2022

To reproduce, connect two nodes, pin the first and run the second two times as a partial execution, i.e. from any of the Execute Node buttons. First node shows two runs the second time.

Fixing by sending only pinData (instead of pinData and runData) for a pinned node.

@linear
Copy link

linear bot commented Sep 26, 2022

N8N-4408

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 26, 2022
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivov ivov merged commit a751fd3 into master Oct 4, 2022
@ivov ivov deleted the n8n-4408-fix-excess-run-in-partial-execution branch October 4, 2022 08:35
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Oct 4, 2022
@janober
Copy link
Member

janober commented Oct 10, 2022

Got released with n8n@0.197.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 10, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
…n-io#4185)

* 🐛 Fix excess run in partial execution

* ⏪ Undo changes to `workflowRun.ts`

* ⚡ Add to `startNodes` only if no `runData`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants