Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Deduplicate error handling in nodes #4319

Merged
merged 6 commits into from
Nov 11, 2022

Conversation

agobrech
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Oct 11, 2022

N8N-3924

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Oct 11, 2022
@agobrech agobrech changed the title :fix core: deduplicate error handeling fix core: deduplicate error handeling Oct 11, 2022
@agobrech agobrech changed the title fix core: deduplicate error handeling fix(core): deduplicate error handling Oct 11, 2022
krynble
krynble previously approved these changes Oct 20, 2022
packages/nodes-base/nodes/Aws/GenericFunctions.ts Outdated Show resolved Hide resolved
packages/nodes-base/nodes/Aws/SES/GenericFunctions.ts Outdated Show resolved Hide resolved
@krynble
Copy link
Contributor

krynble commented Oct 20, 2022

Hey @agobrech approved but I've left a few questions, if you think it's addressed already then you can simply merge

krynble
krynble previously approved these changes Oct 27, 2022
krynble
krynble previously approved these changes Nov 9, 2022
@agobrech agobrech changed the title fix(core): deduplicate error handling fix(core): Deduplicate error handling Nov 9, 2022
@agobrech agobrech changed the title fix(core): Deduplicate error handling fix(core): Deduplicate error handling in nodes Nov 10, 2022
@agobrech agobrech merged commit c7133ec into master Nov 11, 2022
@agobrech agobrech deleted the n8n-3924-node-error-handler-not-behaving-correctly branch November 11, 2022 10:32
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 11, 2022
@janober
Copy link
Member

janober commented Nov 17, 2022

Got released with n8n@0.203.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants