fix(editor): prevent text highlight on FF when mapping data #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
cstuncsik
reviewed
Oct 17, 2022
| @@ -89,6 +89,9 @@ export default Vue.extend({ | |||
| return; | |||
| } | |||
|
|
|||
| e.preventDefault(); | |||
| e.stopPropagation(); | |||
|
|
|||
There was a problem hiding this comment.
I remember not having those on purpose but maybe since then the problem is solved another way
This caused some issues in JSON view but unfortunately I don't remember
Can you check is JSON view mapping is still working fine?
There was a problem hiding this comment.
I tested it and it seemed fine
cstuncsik
approved these changes
Oct 17, 2022
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
…-io#4347) prevent highlight bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.