Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HTTP Request Node): avoid error when response doesn't include content-type #4365

Merged
merged 4 commits into from
Oct 20, 2022
Merged

fix(HTTP Request Node): avoid error when response doesn't include content-type #4365

merged 4 commits into from
Oct 20, 2022

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Oct 18, 2022 •
edited
Loading

@linear
Copy link

linear bot commented Oct 18, 2022

N8N-5049

@RicardoE105 RicardoE105 changed the title fix(HTTP Node): Fix bug when response object do not include content-type fix(HTTP Node): Fix bug when response doesn't include content-type Oct 18, 2022
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Oct 18, 2022
@RicardoE105 RicardoE105 changed the title fix(HTTP Node): Fix bug when response doesn't include content-type fix(HTTP Node): Avoid error when response doesn't include content-type Oct 18, 2022
Joffcom
Joffcom previously approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Joffcom
Joffcom previously approved these changes Oct 19, 2022
View reviewed changes
Joffcom
Joffcom previously approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some more testing with multiple types and all is good

@RicardoE105 RicardoE105 force-pushed the n8n-5049-http-request-v3-has-problems-when-there branch from 4ab8204 to 22d4819 Compare October 20, 2022 15:28
@RicardoE105 RicardoE105 changed the title fix(HTTP Node): Avoid error when response doesn't include content-type fix(HTTP Node): avoid error when response doesn't include content-type Oct 20, 2022
@RicardoE105 RicardoE105 changed the title fix(HTTP Node): avoid error when response doesn't include content-type fix(HTTP Request Node): avoid error when response doesn't include content-type Oct 20, 2022
@RicardoE105 RicardoE105 merged commit 61b9909 into master Oct 20, 2022
@RicardoE105 RicardoE105 deleted the n8n-5049-http-request-v3-has-problems-when-there branch October 20, 2022 15:42
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Oct 20, 2022
@janober
Copy link
Member

janober commented Oct 21, 2022

Got released with n8n@0.199.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 21, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
@RicardoE105
fix(HTTP Request Node): avoid error when response doesn't include con…
2003777 
…tent-type (n8n-io#4365)

* 🐛 Fix bug when response doesn't include content type

* ⚡ Improve autodetect response format

* ⚡ Make content-type match more specific

* ⚡ Improve list of content-types to download
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RicardoE105 @janober @Joffcom