feat(core): Add credential runtime checks and prevent tampering in manual run #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
changed the title
n8n-assistant
bot
added
core
krynble
suggested changes
Nov 4, 2022
There was a problem hiding this comment.
Great work. I think the only necessary change was the one I've mentioned in Linear, where we need to make sure the current user did not tamper the request by changing existing nodes with credentials they don't have access to, neither adding credentials they shouldn't access.
ivov
changed the title
ivov
changed the title
krynble
reviewed
Nov 9, 2022
| }); | ||
| } | ||
|
|
||
| private static mapCredIdsToNodes(workflow: Workflow) { |
There was a problem hiding this comment.
I loved the creation of this function, this is very useful in so many places.
krynble
previously approved these changes
Nov 10, 2022
krynble
approved these changes
Nov 11, 2022
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.