Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(KoBoToolbox Node): Add support for Media file API #4578

Merged
merged 3 commits into from
Dec 6, 2022
Merged

feat(KoBoToolbox Node): Add support for Media file API #4578

merged 3 commits into from
Dec 6, 2022

Conversation

Yann-J
Copy link
Contributor

@Yann-J Yann-J commented Nov 10, 2022 •
edited
Loading

This PR adds support for CRUD operations on a KoboToolbox form's media files, i.e. Create, Get, Delete. These files are used as attachments to a form's content and are typically media files or csv to lookup some data form.

Screenshots:

List all attached files:

image

Attach a new file:

image

Download a file content:

image

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Nov 10, 2022
@Yann-J Yann-J marked this pull request as draft November 10, 2022 20:01
@Yann-J Yann-J changed the title feat(kobo): Media file API feat(KoboToolbox Node): Media file API Nov 10, 2022
@Yann-J Yann-J marked this pull request as ready for review November 10, 2022 20:45
@Yann-J Yann-J changed the title feat(KoboToolbox Node): Media file API feat(KoBoToolbox Node): Media file API Nov 10, 2022
@Yann-J
Copy link
Contributor Author

Yann-J commented Nov 21, 2022

Hello @RicardoE105 small nudge here as I think this one would be quick to review...

@Yann-J
Copy link
Contributor Author

Yann-J commented Nov 30, 2022

Hello! Gentle nudge here... Any timeline for the review?

@RicardoE105
Copy link
Contributor

@Yann-J completely missed this message.

@Joffcom any ETA there?

@Joffcom
Copy link
Member

Joffcom commented Dec 1, 2022

Hey @Yann-J & @RicardoE105,

I missed this one as well, I take it removing the form option from the Hook Get All isn't going to cause any breaking issues?

@Yann-J
Copy link
Contributor Author

Yann-J commented Dec 1, 2022

@Joffcom it is not removed, I just removed the duplicated declarations and regrouped them.

@Joffcom
Copy link
Member

Joffcom commented Dec 1, 2022

@Yann-J so it is, I missed that change on the other option.

@Joffcom
Copy link
Member

Joffcom commented Dec 1, 2022

@Yann-J the only thing that would be worth fixing is removing the ts-ignore from the Trigger as it doesn't appear to do anything there. It isn't part of what you have changed here but I was going to pop it in with this but I don't permission on your branch to do it.

If you can do that quick change while we should be able to get this one merged in time for the next release.

@Yann-J
Copy link
Contributor Author

Yann-J commented Dec 2, 2022

Indeed, not sure what this was doing here... Just removed it! Thanks @Joffcom

@Joffcom
Copy link
Member

Joffcom commented Dec 2, 2022

Hey @Yann-J,

Perfect, So we missed the release today but I will get this merged on Monday to the master branch so it will be in next weeks release.

@Joffcom Joffcom changed the title feat(KoBoToolbox Node): Media file API feat(KoBoToolbox Node): add support for Media file API Dec 6, 2022
@Joffcom Joffcom changed the title feat(KoBoToolbox Node): add support for Media file API feat(KoBoToolbox Node): Add support for Media file API Dec 6, 2022
@Joffcom Joffcom merged commit 37e580e into n8n-io:master Dec 6, 2022
@Joffcom
Copy link
Member

Joffcom commented Dec 6, 2022

Hey @Yann-J,

Thanks for the PR, This has been merged and will be available in the next release.

@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 6, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 6, 2022
@MiloradFilipovic
Merge branch 'master' into feature/undo-redo
69313f1 
* master:
  fix: Handle error when workflow does not exist or is inaccessible (#4831)
  feat(editor): Schema view (#4615)
  fix: Enable source-maps on WorkflowRunnerProcess in `own` mode (#4832)
  ci: Fix linting on master (no-changelog) (#4830)
  feat: Add message for readonly nodes. Improve foreign credentials handling (#4759)
  feat(KoBoToolbox Node): Add support for Media file API (#4578)
  fix(Local File Trigger Node): Fix issue that causes a crash if the ignore field is empty (#4824) (#4825)
  refactor: Codex updates for XML and HtmlExtract Nodes (#4801)
  refactor: Reactivate workflow locking (#4770)

# Conflicts:
#	packages/editor-ui/src/Interface.ts
@janober
Copy link
Member

janober commented Dec 7, 2022

Got released with n8n@0.206.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 7, 2022
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 7, 2022
@Joffcom Joffcom removed the Upcoming Release Will be part of the upcoming release label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yann-J @RicardoE105 @Joffcom @janober