fix(editor): Remove infinite loading in not found workflow level execution #5174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
…-to-access-execution-dont
…-to-access-execution-dont
cstuncsik
changed the title
krynble
approved these changes
Jan 23, 2023
| const executions: IExecutionsSummary[] = | ||
| await this.workflowsStore.loadCurrentWorkflowExecutions(this.filter); | ||
| return executions; | ||
| return await this.workflowsStore.loadCurrentWorkflowExecutions(this.filter); |
There was a problem hiding this comment.
Suggested change
| return await this.workflowsStore.loadCurrentWorkflowExecutions(this.filter); | |
| return this.workflowsStore.loadCurrentWorkflowExecutions(this.filter); |
I think the await statement is not needed here since we return a promise anyway, right?
There was a problem hiding this comment.
Depending on the use case, here return await is desired I think (usually that's the case inside a try-catch block).
https://jakearchibald.com/2017/await-vs-return-vs-return-await/
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 24, 2023
* master: 📚 Update CHANGELOG.md and main package.json to 0.212.1 🔖 Release n8n@0.212.1 ⬆️ Set n8n-core@0.151.2, n8n-editor-ui@0.178.1, n8n-nodes-base@0.210.1 and n8n-workflow@0.133.2 on n8n 🔖 Release n8n-editor-ui@0.178.1 ⬆️ Set n8n-workflow@0.133.2 on n8n-editor-ui 🔖 Release n8n-nodes-base@0.210.1 ⬆️ Set n8n-core@0.151.2 and n8n-workflow@0.133.2 on n8n-nodes-base 🔖 Release n8n-node-dev@0.90.2 ⬆️ Set n8n-core@0.151.2 and n8n-workflow@0.133.2 on n8n-node-dev 🔖 Release n8n-core@0.151.2 ⬆️ Set n8n-workflow@0.133.2 on n8n-core 🔖 Release n8n-workflow@0.133.2 ci: Fix typing issues in cli tests (no-changelog) (#5227) fix(editor): Remove infinite loading in not found workflow level execution (#5174) fix: IsWeekend not checking if DateTime (#5221) (no-changelog) fix(core): Fix execute-once incoming data handling (#5211) fix(core): Make pindata with webhook responding on last node manual-only (#5223) fix(core): Fix onWorkflowPostExecute not being called (#5224) fix(core): Fix expression extension misdetection (#5219) fix: Add schema to postgres migrations (hotfix) (#5218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.