Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Microsoft Teams Node): Overhaul #7477

Merged
merged 36 commits into from
Jan 22, 2024

Conversation

michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team labels Oct 20, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 478 lines in your changes are missing coverage. Please review.

Comparison is base (9883eda) 0.00% compared to head (948d969) 33.65%.

❗ Current head 948d969 differs from pull request most recent head 0296220. Consider uploading reports for the commit 0296220 to get more accurate results

Files Patch % Lines
.../nodes/Microsoft/Teams/v1/MicrosoftTeamsV1.node.ts 4.43% 237 Missing ⚠️
...ase/nodes/Microsoft/Teams/v2/methods/listSearch.ts 8.77% 104 Missing ⚠️
...s-base/nodes/Microsoft/Teams/v2/transport/index.ts 13.51% 32 Missing ⚠️
...icrosoft/Teams/v2/actions/task/update.operation.ts 28.00% 18 Missing ⚠️
...icrosoft/Teams/v2/actions/task/getAll.operation.ts 34.78% 15 Missing ⚠️
...icrosoft/Teams/v2/actions/task/create.operation.ts 36.84% 12 Missing ⚠️
...es-base/nodes/Microsoft/Teams/v2/actions/router.ts 66.66% 10 Missing and 1 partial ⚠️
...des-base/nodes/Microsoft/Teams/v2/helpers/utils.ts 35.29% 11 Missing ⚠️
...t/Teams/v2/actions/chatMessage/create.operation.ts 53.33% 7 Missing ⚠️
...t/Teams/v2/actions/chatMessage/getAll.operation.ts 53.33% 7 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7477       +/-   ##
===========================================
+ Coverage        0   33.65%   +33.65%     
===========================================
  Files           0     3432     +3432     
  Lines           0   208201   +208201     
  Branches        0    22508    +22508     
===========================================
+ Hits            0    70062    +70062     
- Misses          0   136988   +136988     
- Partials        0     1151     +1151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

michael-radency and others added 24 commits October 21, 2023 07:37
Copy link

cypress bot commented Jan 22, 2024

3 flaky tests on run #3866 ↗︎

0 338 5 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: 0296220c8b
Status: Passed Duration: 03:30 💡
Started: Jan 22, 2024 3:16 PM Ended: Jan 22, 2024 3:19 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  19-execution.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Execution > should test manual workflow stop Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #7477 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 2c146cc into master Jan 22, 2024
28 checks passed
@michael-radency michael-radency deleted the node-179-microsoft-teams-node-overhaul branch January 22, 2024 16:35
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
@janober
Copy link
Member

janober commented Jan 24, 2024

Got released with n8n@1.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants