refactor(core): Don't use DB transactions on ExecutionRepository.createNewExecution #8002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
…teNewExecution (no-changelog)
netroy
force-pushed
the
no-transaction-on-exectution-save
branch
from
c9bf57e
to
06c4c6e
Compare
1 flaky test on run #3310 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Node IO Filter > should filter input/output data separately |
Screenshots
Video
|
|
Review all test suite changes for PR #8002 ↗︎
|
✅ All Cypress E2E specs passed |
krynble
approved these changes
Dec 12, 2023
|
✅ All Cypress E2E specs passed |
|
Got released with |
netroy
added a commit
that referenced
this pull request
Dec 15, 2023
…teNewExecution (#8002) Saving execution data is one of the slowest DB operations in the application, and is likely behind some of the sqlite transaction concurrency issues we've been seeing. This not only remove the 2 separate transactions for saving `ExecutionEntity` and `ExecutionData`, but also remove fields from `ExecutionData.workflowData` that don't need to be saved (like `tags`, `shared`, `statistics`, `triggerCount`, etc).
Merged
netroy
added a commit
that referenced
this pull request
Dec 15, 2023
## [1.18.3](https://github.com/n8n-io/n8n/compare/n8n@1.18.2...n8n@1.18.3) (2023-12-15) ### Refactor * **Core:** Don't use DB transactions on `ExecutionRepository.createNewExecution` ([#8002](#8002)) ([f50c14b](f50c14b)) Co-authored-by: netroy <netroy@users.noreply.github.com>
ivov
added a commit
that referenced
this pull request
Dec 15, 2023
## [1.21.1](https://github.com/n8n-io/n8n/compare/n8n@1.21.0...n8n@1.21.1) (2023-12-15) ### Bug Fixes * **ActiveCampaign Node:** Fix pagination issue when loading tags ([#8017](#8017)) ([d661861](d661861)) * **core:** Initialize queue once in queue mode ([#8025](#8025)) ([b1c9c50](b1c9c50)) * **core:** Restore workflow ID during execution creation ([#8031](#8031)) ([2d16161](2d16161)), closes [/github.com//pull/8002/files#diff-c8cbb62ca9ab2ae45e5f565cd8c63fff6475809a6241ea0b90acc575615224](https://github.com//github.com/n8n-io/n8n/pull/8002/files/issues/diff-c8cbb62ca9ab2ae45e5f565cd8c63fff6475809a6241ea0b90acc575615224) * **editor:** Add back credential `use` permission ([#8023](#8023)) ([cf5c723](cf5c723)) * **editor:** Disable auto scroll and list size check when clicking on executions ([#7983](#7983)) ([99d1771](99d1771)) * **editor:** Show credential share info only to appropriate users ([#8020](#8020)) ([9933fce](9933fce)) * **editor:** Turn off executions list auto-refresh after leaving the page ([#8005](#8005)) ([b866a94](b866a94)) Co-authored-by: ivov <ivov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Saving execution data is one of the slowest DB operations in the application, and is likely behind some of the sqlite transaction concurrency issues we've been seeing.
This not only remove the 2 separate transactions for saving
ExecutionEntityandExecutionData, but also remove fields fromExecutionData.workflowDatathat don't need to be saved (liketags,shared,statistics,triggerCount, etc).Review / Merge checklist