fix(AwsS3 Node): Return confirmation of success after upload #8312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
n8n team
elsmr
approved these changes
Jan 12, 2024
michael-radency
changed the title
|
|
3 flaky tests on run #3766 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Workflow tags > should create and attach tags inline |
Test Replay
Screenshots
Video
|
|
17-sharing.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
|
29-templates.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Templates > should save template id with the workflow |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8312 ↗︎
…aws-s3-upload-doesnt-return-result-items
Joffcom
approved these changes
Jan 15, 2024
|
✅ All Cypress E2E specs passed |
michael-radency
deleted the
node-788-aws-s3-upload-doesnt-return-result-items
branch
netroy
pushed a commit
that referenced
this pull request
Jan 16, 2024
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AWS S3: Upload doesn't return result items
Related tickets and issues
https://linear.app/n8n/issue/NODE-788/aws-s3-upload-doesnt-return-result-items