Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Venafi TLS Protect Cloud Trigger Node): Handle new webhook payload format #8326

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix(Venafi TLS Protect Cloud Trigger Node): Handle new webhook payload format #8326

merged 1 commit into from
Jan 15, 2024

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Jan 12, 2024 •
edited
Loading

Summary

Venafi updated how the webhooks events are sent. This PR fixes the issue as the node is useless right now

Review / Merge checklist

  • [x ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)

@RicardoE105 RicardoE105 changed the title Update trigger logic fix(Venafi TLS Protect Cloud Trigger Node): Handle new webhook payload format Jan 12, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jan 13, 2024
@Joffcom
Copy link
Member

Joffcom commented Jan 13, 2024

@RicardoE105 don't forget to remove the console logs

@RicardoE105 RicardoE105 marked this pull request as draft January 13, 2024 02:19
@RicardoE105 RicardoE105 marked this pull request as ready for review January 14, 2024 05:39
@cypress Cypress
Copy link

cypress bot commented Jan 15, 2024

1 flaky test on run #3760 ↗︎

0 331 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project: n8n Commit: 13bb4eb525
Status: Passed Duration: 03:24 💡
Started: Jan 15, 2024 1:54 PM Ended: Jan 15, 2024 1:58 PM
Flakiness  cypress/e2e/30-editor-after-route-changes.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Editor actions should work > after switching between Editor and Executions Test Replay Screenshots Video

Review all test suite changes for PR #8326 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 057d7d0 into master Jan 15, 2024
28 checks passed
@RicardoE105 RicardoE105 deleted the nodes/fix-venafi-trigger branch January 15, 2024 14:03
netroy pushed a commit that referenced this pull request Jan 16, 2024
@RicardoE105 @netroy
fix(Venafi TLS Protect Cloud Trigger Node): Handle new webhook payloa…
7680723 
…d format (#8326)
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Merged
@janober
Copy link
Member

janober commented Jan 16, 2024

Got released with n8n@1.24.1

@github-actions github-actions bot mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RicardoE105 @Joffcom @janober