Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change the UI text for some filter operations #8360

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

StarfallProjects
Copy link
Contributor

This PR does two things:

  • Small changes to some of the help text in the switch node
  • Suggests changing the UI text for some filter comparisons: anything that is X or equal should be X or equal to. For example, change length greater than or equal to length greater than or equal to. Reason: in the filter component, it looks like we're trying to create natural sounding sentences for the comparisons. For example, in the switch node, you can compare two strings with is equal to so you end up with x is equal to y. However, a few of the options are missing the to, and it reads oddly.

Joffcom
Joffcom previously approved these changes Jan 17, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels Jan 17, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 17, 2024

1 flaky test on run #3811 ↗︎

0 334 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 StarfallProjects 🗃️ e2e/*
Project: n8n Commit: a8fd5eb14e
Status: Passed Duration: 03:18 💡
Started: Jan 18, 2024 8:46 AM Ended: Jan 18, 2024 8:49 AM
Flakiness  cypress/e2e/24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #8360 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@StarfallProjects StarfallProjects merged commit 976fe2e into master Jan 18, 2024
28 checks passed
@StarfallProjects StarfallProjects deleted the switch-text-suggestions branch January 18, 2024 08:50
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
@janober
Copy link
Member

janober commented Jan 22, 2024

Got released with n8n@1.25.1

@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants