Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue preventing secrets with a - in the path from being imported #8378

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jan 18, 2024

Summary

When I added the secrets change to add support for / and - I was working on 2 branches and forgot to add the \- for the regex so we include it.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 18, 2024
Copy link

cypress bot commented Jan 18, 2024

Passing run #3813 ↗︎

0 336 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: 00e4870e18
Status: Passed Duration: 03:19 💡
Started: Jan 18, 2024 9:17 AM Ended: Jan 18, 2024 9:21 AM

Review all test suite changes for PR #8378 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit fc94377 into master Jan 18, 2024
28 checks passed
@Joffcom Joffcom deleted the secrets-typo branch January 18, 2024 09:24
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
@janober
Copy link
Member

janober commented Jan 22, 2024

Got released with n8n@1.25.1

@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants