-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Adjust starter node priority for manual executions with pinned activators #8386
Merged
ivov
merged 2 commits into
master
from
adjust-starter-node-priority-for-manual-executions-with-pinned-activators
Jan 19, 2024
Merged
fix(core): Adjust starter node priority for manual executions with pinned activators #8386
ivov
merged 2 commits into
master
from
adjust-starter-node-priority-for-manual-executions-with-pinned-activators
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
Jan 18, 2024
krynble
previously approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Passing run #3831 ↗︎
Details:
Review all test suite changes for PR #8386 ↗︎ |
|
1 similar comment
|
krynble
approved these changes
Jan 19, 2024
✅ All Cypress E2E specs passed |
ivov
deleted the
adjust-starter-node-priority-for-manual-executions-with-pinned-activators
branch
January 19, 2024 09:18
Merged
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://linear.app/n8n/issue/PAY-1099
This PR adjusts starter node priority for manual executions with pinned activators, prioritizing
n8n-nodes-base.webhook
and ignoringn8n-nodes-base.respondToWebhook
.