Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Asana Node): Fix issue when connecting to the new Asana environment #8404

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jan 22, 2024

Summary

This fixes an issue that was preventing the Asana and Asana Trigger node from connecting to the updated Asana environment.

Related tickets and issues

#8403
https://community.n8n.io/t/asana-returns-error-403-for-get-requests-after-implementing-cdn/35605

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jan 22, 2024
Copy link

cypress bot commented Jan 22, 2024

3 flaky tests on run #3861 ↗︎

0 338 5 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: 4d6736d6be
Status: Passed Duration: 03:29 💡
Started: Jan 22, 2024 11:47 AM Ended: Jan 22, 2024 11:51 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video
Flakiness  28-debug.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Debug > should be able to debug executions Test Replay Screenshots Video

Review all test suite changes for PR #8404 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 44f6ef2 into master Jan 22, 2024
31 checks passed
@Joffcom Joffcom deleted the gh/8403 branch January 22, 2024 12:39
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
@janober
Copy link
Member

janober commented Jan 22, 2024

Got released with n8n@1.25.1

@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants