Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Give better error message if executions.process is still used in the configs #8618

Merged

Conversation

despairblue
Copy link
Contributor

@despairblue despairblue commented Feb 13, 2024

Summary

Print something actionable instead of Error Plugin: n8n: configuration param 'executions.process' not declared in the schema.
This will print Own mode has been removed. If you need the isolation and performance gains, please consider using queue mode. instead. Just the same as when EXECUTIONS_PROCESS is set.

Related tickets and issues

https://linear.app/n8n/issue/PAY-1363/removing-own-mode-wasnt-marked-as-a-breaking-change

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 13, 2024
Copy link

cypress bot commented Feb 13, 2024

2 flaky tests on run #4086 ↗︎

0 343 5 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 despairblue 🗃️ e2e/*
Project: n8n Commit: 1000a1fb7c
Status: Passed Duration: 03:31 💡
Started: Feb 13, 2024 12:35 PM Ended: Feb 13, 2024 12:38 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #8618 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@krynble krynble merged commit cd8ca84 into master Feb 13, 2024
30 checks passed
@krynble krynble deleted the pay-1363-removing-own-mode-wasnt-marked-as-a-breaking-change branch February 13, 2024 12:40
netroy pushed a commit that referenced this pull request Feb 14, 2024
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
@janober
Copy link
Member

janober commented Feb 15, 2024

Got released with n8n@1.27.3

@github-actions github-actions bot mentioned this pull request Feb 15, 2024
despairblue added a commit that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants