fix(core): Improve the startup error when EXECUTIONS_PROCESS is set #8630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
force-pushed
the
own-mode-error
branch
from
e40de08
to
0a6d0e3
Compare
despairblue
previously approved these changes
Feb 14, 2024
krynble
previously approved these changes
Feb 14, 2024
Co-authored-by: Omar Ajoue <krynble@gmail.com>
krynble
approved these changes
Feb 14, 2024
despairblue
approved these changes
Feb 14, 2024
1 flaky test on run #4099 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8630 ↗︎
|
✅ All Cypress E2E specs passed |
netroy
added a commit
that referenced
this pull request
Feb 14, 2024
…8630) Co-authored-by: Omar Ajoue <krynble@gmail.com>
Merged
|
Got released with |
Merged
despairblue
pushed a commit
that referenced
this pull request
Feb 16, 2024
…8630) Co-authored-by: Omar Ajoue <krynble@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the check much early on, and removed all references to
EXECUTIONS_PROCESSoutsidebin/n8n. It also adds a more clearly understandable error/warning message for whenEXECUTIONS_PROCESSis set.Own mode
Main Mode
Review / Merge checklist