Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix empty node name handling #9548

Merged
merged 4 commits into from
May 30, 2024

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented May 30, 2024

Summary

This PR fixes the way we handle empty node names:

  • Preventing setting empty when renaming node using keyboard shortcut
  • Making sure nodes get assigned a new name when importing nodes with empty names

Related tickets and issues

Fixes ADO-1969
#9430

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@MiloradFilipovic MiloradFilipovic self-assigned this May 30, 2024
@MiloradFilipovic MiloradFilipovic changed the title fix(edior): Fix empty node name handling fix(editor): Fix empty node name handling May 30, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 30, 2024
Co-authored-by: oleg <me@olegivaniv.com>
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented May 30, 2024

1 flaky test on run #5180 ↗︎

0 361 0 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project: n8n Commit: 391fc9b3f1
Status: Passed Duration: 04:40 💡
Started: May 30, 2024 1:10 PM Ended: May 30, 2024 1:14 PM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video

Review all test suite changes for PR #9548 ↗︎

@MiloradFilipovic MiloradFilipovic merged commit da41d31 into master May 30, 2024
28 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-1969-fix-empty-node-names branch May 30, 2024 13:25
@github-actions github-actions bot mentioned this pull request May 30, 2024
@janober
Copy link
Member

janober commented May 30, 2024

Got released with n8n@1.44.0

MiloradFilipovic added a commit that referenced this pull request May 31, 2024
* master:
  fix(editor): Fix ts errors across the board (no-changelog) (#9561)
  refactor(core): Extract all Auth-related User columns into a separate entity (#9557)
  refactor(core): Update supertest, and fix some typing errors (no-changelog) (#9527)
  fix(editor): Render checkboxes in markdown (#9549)
  test(core): Rename and combine all credential api tests (no-changelog) (#9550)
  🚀 Release 1.44.0 (#9553)
  feat(editor): Node Creator AI nodes improvements  (#9484)
  fix(editor): Show workflow data in header when execution page is hard reloaded (#9529)
  refactor(core): Stop reporting to Sentry `NodeApiError` with 5xx status codes (no-changelog) (#9552)
  feat: HighLevel oauth2 api credentials (#9542)
  fix(editor): Fix empty node name handling (#9548)
  ci: Fix vulnerable dev dependencies (no-changelog) (#9545)
  fix: Don't throw errors for NaN in number operators in the filter component  (#9506)
  fix(core): Try setting postgres search_path on the database (#9530)
  fix(editor): Redirect to workflows list after deleting a workflow (#9546)

# Conflicts:
#	packages/editor-ui/src/views/NodeView.vue
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants