-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Invoice Ninja Node): Fix emailing and marking invoice as paid / sent #9589
Merged
netroy
merged 10 commits into
n8n-io:master
from
CodeShakingSheep:invoiceninja-fix-invoice-paid-and-email
Jul 4, 2024
Merged
fix(Invoice Ninja Node): Fix emailing and marking invoice as paid / sent #9589
netroy
merged 10 commits into
n8n-io:master
from
CodeShakingSheep:invoiceninja-fix-invoice-paid-and-email
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…markSent; rename emailInvoice to sendEmail; Interface: Remove email_invoice, email; rename paid to paid_to_date
CodeShakingSheep
changed the title
fix(Invoice Ninja node): Fix emailing and marking invoice as paid / sent
fix(Invoice Ninja Node): Fix emailing and marking invoice as paid / sent
Jun 2, 2024
n8n-assistant
bot
added
community
Authored by a community member
node/improvement
New feature or request
in linear
Issue or PR has been created in Linear for internal review
labels
Jun 2, 2024
3 tasks
Joffcom
previously approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, Thanks for this.
netroy
approved these changes
Jul 4, 2024
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
Authored by a community member
in linear
Issue or PR has been created in Linear for internal review
node/improvement
New feature or request
Released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the following 2 actions for InvoiceNinja API v5 which aren't working properly.
The background of this is that API v5 introduced query string parameters for these actions
send_email
andpaid
/amount_paid
. See https://api-docs.invoicing.co/#post-/api/v1/invoices. Compared to that API v4 used differently named body params for these actions.Additionally this PR adds
mark_sent
as query param to be able to mark an invoice as sent after creating it (which I personally need a lot). Also, I fixed a small typo in the description for emailing anquote.At first, I was making these changes just having API v5 in mind before I realized that this node still needs to support API v4. So, afterwards I reverted the what I believed to be breaking changes and only extended the existing logic to make it compatible with API v5.
Related tickets and issues
None available. I just used the InvoiceNinja node and figured that marking an invoice as paid or sent isn't working and neither emailing an invoice (directly form the "Create invoice" node).
Review / Merge checklist