Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Allow graceful shutdown for main with active executions #9661

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 7, 2024

Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Jun 7, 2024

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jun 7, 2024

1 flaky test on run #5355 ↗︎

0 362 0 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 900cb19e1f
Status: Passed Duration: 04:58 💡
Started: Jun 7, 2024 8:51 AM Ended: Jun 7, 2024 8:56 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9661 ↗︎

@ivov ivov merged commit 4b345be into master Jun 7, 2024
28 checks passed
@ivov ivov deleted the pay-1645-bug-allow-shutdown-for-main-process branch June 7, 2024 08:58
This was referenced Jun 12, 2024
@janober
Copy link
Member

janober commented Jun 12, 2024

Got released with n8n@1.44.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants