-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Handling Issue in HTTP Request Node during PUT Operation #9665
Comments
Hey @domcaram, What other settings do you have in the node? I have just given this a test with the |
Hey @Joffcom, The only customization I have made is setting the timeout to 50000 Thank you P.S. I have tried updating the image to 1.45.0 but still encounter the same error. |
@domcaram which version did you upgrade from? If you click on the settings for the HTTP Request node at the bottom it should show a node version, What is that version? |
@Joffcom i just upgraded from 1.44.1 to 1.45.0. (HTTP Request node version 1 (Latest version: 4.2)) |
@domcaram I suspect that is node version won't help can you add a new http request node and see if that has the same option. With the upgrade before you went to 1.44.1 which version were you running? |
@Joffcom adding a new HTTP Request node shows a slightly different version and module: To update n8n, I use watchtower, which checks daily for new latest versions. This workflow originates from one of the earliest versions of n8n (possibly 0.2) I'm now trying with the new version |
@domcaram I guess that means you were on 1.42 before which is a big help tracking down the change as I noticed it is still in 1.43. |
@Joffcom Yes that's probably correct. On 1.42 it was working, I also tried downgrading the image but during the container startup I get an
|
Hey @Joffcom, I just saw that this issues has been fixed and merged in master. May I ask when this will be live? Thank you |
Hey @domcaram, I suspect there will be a 1.45.1 release at some point, It may be Monday now though. When there is a release a note will be popped on here to let you know. |
Any news on 1.45.1, @Joffcom? This is breaking our automations 🫣 |
Same problem here when use UPDATE operation in SQL from n8n.
This is breaking my automations :*{ This is breaking my automations :( |
Fix got released with |
Updating will resolve this, Let me know how you get on after an update and if it is still an issue. |
Bug Description
When attempting to perform a PUT request using the HTTP Request node in n8n, I encounter the following error:
Cannot read properties of undefined (reading 'error')
Full Stack Trace:
TypeError: Cannot read properties of undefined (reading 'error') at /usr/local/lib/node_modules/n8n/node_modules/n8n-core/dist/WorkflowExecute.js:666:253 at processTicksAndRejections (node:internal/process/task_queues:95:5) at /usr/local/lib/node_modules/n8n/node_modules/n8n-core/dist/WorkflowExecute.js:1079:20
Although the PUT request appears to proceed as expected, it seems that the code attempts to read the error property even when there is no error present in the response. This forced reading of the error variable causes the TypeError mentioned above.
To Reproduce
Expected behavior
The workflow should handle responses without errors gracefully and should not attempt to read the error property when it is undefined.
Operating System
Debian 12 (Bookworm)
n8n Version
1.44.1
Node.js Version
v20.13.1
Database
SQLite (default)
Execution mode
main (default)
The text was updated successfully, but these errors were encountered: