Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add custom data to public API execution endpoints #9705

Merged
merged 2 commits into from
Jun 17, 2024
Merged

feat(core): Add custom data to public API execution endpoints #9705

merged 2 commits into from
Jun 17, 2024

Conversation

valya
Copy link
Contributor

@valya valya commented Jun 11, 2024

Summary

Adds execution custom data (metadata) to the public API execution endpoints when includeData=true is sent.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 11, 2024
@cypress Cypress
Copy link

cypress bot commented Jun 14, 2024 •
edited
Loading

Passing run #5510 ↗︎

0 393 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 valya 🗃️ e2e/*
Project: n8n Commit: 1310af63a7
Status: Passed Duration: 04:11 💡
Started: Jun 17, 2024 9:57 AM Ended: Jun 17, 2024 10:01 AM

Review all test suite changes for PR #9705 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@valya
Merge remote-tracking branch 'origin/master' into pay-1625-return-cus…
1310af6 
…tom-data-when-fetching-executions-via-the-public
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@krynble krynble merged commit a104660 into master Jun 17, 2024
31 checks passed
@krynble krynble deleted the pay-1625-return-custom-data-when-fetching-executions-via-the-public branch June 17, 2024 11:38
adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jun 20, 2024
@valya @adrian-martinez-onestic
feat: Add custom data to public API execution endpoints (n8n-io#9705)
a86702a
adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jun 20, 2024
@valya @adrian-martinez-onestic
feat: Add custom data to public API execution endpoints (n8n-io#9705)
1234933
@github-actions github-actions bot mentioned this pull request Jun 20, 2024
Merged
@netroy netroy changed the title feat: Add custom data to public API execution endpoints feat(core): Add custom data to public API execution endpoints Jun 20, 2024
@github-actions github-actions bot mentioned this pull request Jun 20, 2024
Merged
@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with n8n@1.47.0

1 similar comment
@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with n8n@1.47.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valya @janober @krynble